Pull Request Test Coverage Report for Build 6977754646

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 146 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.02%) to 40.094%

Totals
Change from base Build 6973422803:	-0.02%
Covered Lines:	10699
Relevant Lines:	26685

💛 - Coveralls

Hey @jlonge4, we are very busy with the upcoming 2.0 release these days.

So probably the review process may be a bit long... Please bear with us.

@anakin87 No worries! I totally understand

@tstadel no worries I appreciate the feedback! Everything should be implemented, however some weird failures related to files I hadn't even touched that I didn't get last time.

@anakin87 was that a merge in the wrong direction? 😅

I fixed mypy and pylint errors.

In general, it looks good, but I haven't tried these changes locally....

@tstadel can you take another look?

@anakin87 @jlonge4 I did some final refactorings and fixed two things:

• rename session_token to aws_session_token to be consistent with boto3
• set truncate: 'RIGHT' for cohere request payloads according to https://docs.aws.amazon.com/bedrock/latest/userguide/model-parameters-embed.html (with END it did not work)

Also for cohere we use batch mode now. I made some final tests locally to ensure doc and query embeddings are working with titan and cohere models.

So from my side we can merge now :-)

@anakin87 wait I've found another thing to improve:

• we should throw AWSConfigurationError instead of ValueError if an error occurs during boto3 session init. I'll quickly fix that.

@anakin87 ok now we're good to go.

@tstadel @anakin87 thank you both so much for the help and patience!